Skip to content

Commit

Permalink
Merge pull request #32 from openreview/feature/remove-dependencies
Browse files Browse the repository at this point in the history
Chore: Remove node-fetch dependency
  • Loading branch information
xkopenreview committed Mar 19, 2024
2 parents ad307fc + 0bff2ac commit 4e56981
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 24 deletions.
20 changes: 0 additions & 20 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions packages/client/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@openreview/client",
"version": "0.0.27",
"version": "0.0.28",
"description": "Node.js client library for OpenReview's academic publishing API",
"main": "src/index.js",
"type": "module",
Expand Down Expand Up @@ -33,7 +33,6 @@
"fast-xml-parser": "^4.3.2",
"form-data-encoder": "^1.9.0",
"formdata-node": "^4.4.1",
"node-fetch": "^2.7.0",
"tldjs": "^2.3.1"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/client/src/client.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use strict';

import fetch from 'node-fetch';
import fs from 'fs';
import { FormData } from 'formdata-node';
// eslint-disable-next-line import/no-unresolved
Expand Down Expand Up @@ -503,7 +502,8 @@ export default class OpenReviewClient {
const data = await this._handleResponse(fetch(this.attachmentUrl, {
method: 'PUT',
headers: { ...this.headers, ...encoder.headers },
body: Readable.from(encoder)
body: Readable.from(encoder),
duplex: 'half'
}), { url: '' });

return data;
Expand Down

0 comments on commit 4e56981

Please sign in to comment.