Merge pull request #32 from openreview/feature/remove-dependencies

Chore: Remove node-fetch dependency
openreview · Mar 19, 2024 · 4e56981 · 4e56981
2 parents ad307fc + 0bff2ac
commit 4e56981
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 24 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/client/package.json b/packages/client/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@openreview/client",
-  "version": "0.0.27",
+  "version": "0.0.28",
   "description": "Node.js client library for OpenReview's academic publishing API",
   "main": "src/index.js",
   "type": "module",
@@ -33,7 +33,6 @@
     "fast-xml-parser": "^4.3.2",
     "form-data-encoder": "^1.9.0",
     "formdata-node": "^4.4.1",
-    "node-fetch": "^2.7.0",
     "tldjs": "^2.3.1"
   },
   "devDependencies": {

diff --git a/packages/client/src/client.js b/packages/client/src/client.js
@@ -1,6 +1,5 @@
 'use strict';
 
-import fetch from 'node-fetch';
 import fs from 'fs';
 import { FormData } from 'formdata-node';
 // eslint-disable-next-line import/no-unresolved
@@ -503,7 +502,8 @@ export default class OpenReviewClient {
     const data = await this._handleResponse(fetch(this.attachmentUrl, {
       method: 'PUT',
       headers: { ...this.headers, ...encoder.headers },
-      body: Readable.from(encoder)
+      body: Readable.from(encoder),
+      duplex: 'half'
     }), { url: '' });
 
     return data;