Merge pull request #46 from openreview/fix/extract-abtract-error-hand…

…ling

Fix/extract abstract error handling

packages/client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openreview/client",
-  "version": "0.0.29",
+  "version": "0.0.30",
   "description": "Node.js client library for OpenReview's academic publishing API",
   "main": "src/index.js",
   "type": "module",

packages/client/src/tools.js

@@ -6,6 +6,7 @@ import { fileURLToPath } from 'url';
 import { XMLParser } from 'fast-xml-parser';
 import pkg from 'tldjs';
 import { generateQueryString } from './helpers.js';
+import OpenReviewError from './errors.js';
 
 const { isValid, getDomain } = pkg;
 
@@ -879,11 +880,23 @@ export default class Tools {
    * @param {string} url - The url from which the abstract and the PDF are to be extracted
    * @returns {object} The abstract and the PDF
    */
-  static extractAbstract(url) {
+  static async extractAbstract(url) {
     const metaExtractionUrl = 'https://meta-extraction-wivlbyt6ga-uc.a.run.app/metadata';
     const queryString = generateQueryString({ url });
-    return fetch(`${metaExtractionUrl}?${queryString}`, {
+    const result = await fetch(`${metaExtractionUrl}?${queryString}`, {
       method: 'GET',
     });
+
+    if (result.status === 200) {
+      return result.json();
+    }
+
+    const contentType = result.headers.get('content-type');
+    throw new OpenReviewError({
+      name: 'ExtractAbstractError',
+      message: (contentType && contentType.indexOf('application/json') !== -1) ? await result.json().message : await result.text(),
+      status: result.status || 500
+    });
+
   }
 }

packages/client/test/test.js

@@ -802,4 +802,16 @@ describe('OpenReview Client', function () {
     }
   });
 
+  it('should try to extract the abstract but get a 404 error', async function () {
+
+    try {
+      await Tools.extractAbstract('https://doi.org/10.1007/978-981-99-1549-1_15');
+    } catch (error) {
+      assert.equal(error.name, 'ExtractAbstractError');
+      assert.match(error.message, /Error: Page not found/);
+      assert.equal(error.status, 404);
+    }
+
+  });
+
 });