Fix/extract abstract error handling #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/client/src/tools.js
Outdated
| const contentType = result.headers.get('content-type'); | ||
| throw new OpenReviewError({ | ||
| name: 'ExtractAbstractError', | ||
| message: (contentType && contentType.indexOf('application/json') !== -1) ? await result.json() : await result.text(), |
There was a problem hiding this comment.
I think you have to get the message value from the json
Suggested change
| message: (contentType && contentType.indexOf('application/json') !== -1) ? await result.json() : await result.text(), | |
| message: (contentType && contentType.indexOf('application/json') !== -1) ? (await result.json()).message : await result.text(), |
There was a problem hiding this comment.
I wasn't sure if the json has the message property but I can do that.
packages/client/src/tools.js
Outdated
| @@ -882,8 +883,20 @@ export default class Tools { | |||
| static extractAbstract(url) { | |||
| const metaExtractionUrl = 'https://meta-extraction-wivlbyt6ga-uc.a.run.app/metadata'; | |||
| const queryString = generateQueryString({ url }); | |||
| return fetch(`${metaExtractionUrl}?${queryString}`, { | |||
| const request = fetch(`${metaExtractionUrl}?${queryString}`, { | |||
There was a problem hiding this comment.
You could also change the extractAbstract function to be async and use await here 😬, but it's not necessary.
Suggested change
| const request = fetch(`${metaExtractionUrl}?${queryString}`, { | |
| const result = await fetch(`${metaExtractionUrl}?${queryString}`, { |
| const metaExtractionUrl = 'https://meta-extraction-wivlbyt6ga-uc.a.run.app/metadata'; | ||
| const queryString = generateQueryString({ url }); | ||
| return fetch(`${metaExtractionUrl}?${queryString}`, { | ||
| const result = await fetch(`${metaExtractionUrl}?${queryString}`, { | ||
| method: 'GET', |
There was a problem hiding this comment.
not related to this pr but i think the option param is redundant
xkopenreview
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the status code and throw an exception if it is different than 200.