-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ARR Cycles to Independent API2 Requests #1836
Conversation
This is great, a good starting point. I guess we need to update the test to use ARR as a venueid. About the scripts listed here, do you a have a link to the other repo so we can use them as reference? We can start putting these scripts in a ARR folder and call them from the test and then test the workflow. What do you think? |
exp_date=note.content.get('ae_checklist_exp_date'), | ||
process='process/checklist_process.py', | ||
preprocess='process/checklist_preprocess.py', | ||
extend=extend_ae_checklist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this extend for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extend
functions are called as a post-processing step after the invitation is created if something about the invitation needs to be changed that wasn't supported by the built-in stages. The extend checklist functions modify the super invitations so that they are compatible with the ethics flagging code for changing the readers
The same idea for the build_edit
functions because sometimes edits need to be built with some additional logic (though for the pre-print case I think it can be removed, it seems simple enough to put everything in the edit without additional code)
This PR integrates the updated ARR workflow into
openreview-py
and migrates the venue to API2. The following steps are currently handled by scripts outside ofopenreview-py
:Overview of Changes
Location of ARR JSON forms
openreview-py/openreview/arr/invitation.py
Line 128 in 59a754a
ARRStage
objects:openreview-py/openreview/arr/helpers.py
Line 1139 in 59a754a
Adding New Workflow Steps
openreview-py/openreview/arr/helpers.py
Line 39 in 59a754a
arr_content.py
file and add the import to the helpers file.Example
Task List
previous_URL
field is a link to OpenReview only containing/forum?id=
)Note From EiCs: These are the confidential supplementary materials of the submission. If you see no entries in this comment, this means there haven't been submitted any.
Official_Review
process function to create aConsent
invitation for the reviewer to reply to their own review to consent for this review to be used for research. Also, emails the ethics chairs for flagged papers and re-runs the ethics stage. If there is a potential anonymity violation, email the editors and create a paper desk reject verification invitation.Research_Area
invitation by reading the registration and unavailability notesReviewers/Submitted
group of resubmissions to theReviewers/Submitted
group of the previous submissionOfficial_Review
/Meta_Review
invitations with different content and no email notifications) Emails the ethics chairs for flagged papers, re-runs the ethics stage and reveals all checklists to the ethics reviewers/chairs. If there is a potential anonymity violation, email the editors and create a paper desk reject verification invitation.Official_Review
invitation and re-posts it after the ethics stage is run to keep the process function)/-/Emergency
invitation in their browse param.