-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/DBLP abstract extraction process change #1993
Conversation
@@ -0,0 +1,28 @@ | |||
async function process(client, edit, invitation) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the abstract invitation should have a process function to extract the abstract?
This is invitation is being to set the abstract value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to allow manual triggering of abstract extraction when the process function in DBLP.org/-/Record fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but the abstract in the edit would be empty or what?
if the edit has a value, do you overwrite it?
and it is seems to be an infinite loop here, you are posting an edit with the same invitation of the process function.
|
||
const html = note.content.html?.value; | ||
|
||
if (html) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great! should we do the same to extract the PDF link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it necessary to extract the PDF link?
from what i understand it's just the redirected url of html, not the link to a .pdf file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure but Andrew wants to complete the PDF value with the link to the PDF not to a webpage.
to test importing many dblp papers in v2, existing notes in v1 need to be removed (so that there's no match) |
can you try Andrew's profile? there are a lot of new publications that were not imported or we can pick another profile that doesn't exist in the dev site and create it. |
discussed with @carlosmondra again about this and decided to:
so that there's no dependency between meta-extraction package and api and both fetch and cloud function url are not exposed. |
In order the test to pass we may need to mock the service or something similar. Maybe if |
discussed with Carlos again about this |
the test failure looks random to me
@melisabok can you help to rerun the test |
checking now. |
Some API 1 tests are failing because I think |
A try/catch was missing in the abstract process function, tests should pass now. |
this pr should update the process function