allow ACs to delete pending invite assignment edges #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melisabok
reviewed
Jan 29, 2024
| const conflictPolicy = invitation.content.reviewers_conflict_policy?.value | ||
| const conflictNYears = invitation.content.reviewers_conflict_n_years?.value | ||
|
|
||
| if (edge.ddate) { | ||
| if (edge.label === acceptedLabel) { | ||
| return Promise.reject(new OpenReviewError({ name: 'Error', message: `Edge cannot be removed as the user has already accepted the invitation.` })) |
There was a problem hiding this comment.
I would change the error message to something more use friendly: "Can not remove the invitation because the invitations was already accepted" or "Can not remove the invitations because it was already responded".
Instead of having an if for each status, can we show a parametrized one? there might be in the future another states so I would prefer to check if the edge.label != "Invitation Sent" then throw error
melisabok
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.