Feature/Venue: parametrize review stage #2021
Conversation
| process_path = None | ||
| process_path = None, | ||
| content_query = {}, | ||
| child_invitations_name = 'Official_Review' |
There was a problem hiding this comment.
I think name should represent the child invitation name.
There was a problem hiding this comment.
we should have a parent_name that is optional and by default it is the name value
openreview/stages/venue_stages.py
Outdated
| @@ -539,7 +539,9 @@ def __init__(self, | |||
| remove_fields = [], | |||
| rating_field_name = 'rating', | |||
| confidence_field_name = 'confidence', | |||
| process_path = None | |||
| process_path = None, | |||
| content_query = {}, | |||
There was a problem hiding this comment.
I'm not sure about calling content_query, it doesn't indicate that is the source of submissions that we want to create the review invitations.
what about:
- selected_submissions
- selected_submissions_query
- selected_submissions_content_query
- forums_query
- selected_forums
- replyto_query
...
| @@ -65,6 +67,10 @@ def get_children_notes(): | |||
| if source == 'flagged_for_ethics_review': | |||
| source_submissions = [s for s in source_submissions if s.content.get('flagged_for_ethics_review', {}).get('value', False)] | |||
|
|
|||
| if content_query: | |||
| for key, value in content_query.items(): | |||
| source_submissions = [s for s in source_submissions if value in s.content.get(key, {}).get('value', '')] | |||
There was a problem hiding this comment.
I think in is better, it will work for strings and arrays.
|
The changes look good, it is very simple. I made some comments about naming conventions. |
|
@melisabok Great! I can make those changes. I did find one issue with the ethics review stage: When a paper is flagged, we update the review invitation and the reviews to include ethics reviewers as readers: This is updating the paper invitation using the default super review invitation. How can we denote which super invitation should be used here? This also means that when the ethics review stage is run, we need to somehow get both review forms and update them both, but now only the default one gets updated. |
This PR adds two params to the Review Stage:
source_submissions_query: the query by which to filter paperschild_invitations_name: the name of the children invitations, since it can be different from the super invitation nameinvitation_edit_process.pyfilters papers by source_submissions_query, and creates/updates official invitations only for these papers.Requires https://github.com/openreview/openreview-api/pull/362