Chat feature: enable chat in the venue request form #2029
Conversation
|
@melisabok can you share the invitation configuration you were using with |
|
@zbialecki I pushed a change using items, I kept the line to use enum in case you need it. |
| if self.Readers.REVIEWERS_ASSIGNED in self.invitees: | ||
| invitees.append(conference.get_reviewers_id(number)) | ||
|
|
||
| if self.Readers.REVIEWERS_SUBMITTED in self.invitees: |
There was a problem hiding this comment.
I don't think we need both Reviewers and Reviewers/Submitted right?
There was a problem hiding this comment.
it depends on which participants they choose in the CommentStage.
There was a problem hiding this comment.
but Reviewers/Submitted could be an option.
There was a problem hiding this comment.
OK, it makes sense that Reviewers/Submitted could be an option, but both Reviewers and Reviewers/Submitted shouldn't be in readers at the same time. It's confusing in the UI if it says the chat is visible to Reviewers and Reviewers/Submitted
|
Some issues I'm seeing with the tests:
|
…view/openreview-py into feature/enable-chat-comment-stage
tests/test_icml_conference.py
Outdated
| @@ -4484,8 +4484,9 @@ def test_meta_review_agreement(self, client, openreview_client, helpers, seleniu | |||
| invitations_container = selenium.find_element(By.CLASS_NAME, 'invitations-container') | |||
| invitation_buttons = invitations_container.find_element(By.CLASS_NAME, 'invitation-buttons') | |||
| buttons = invitation_buttons.find_elements(By.TAG_NAME, 'button') | |||
| assert len(buttons) == 1 | |||
| assert len(buttons) == 2 | |||
There was a problem hiding this comment.
I think this should actually be changed back - we decided that the forum page will default to the discussion tab, so the chat button will be hidden.
There was a problem hiding this comment.
yes, I changed it to make the tests pass
…view/openreview-py into feature/enable-chat-comment-stage
openreview/venue/invitation.py
Outdated
| ) | ||
| ) | ||
|
|
||
| emoji_chat_invitation = self.venue.get_invitation_id('Chat_Emoji') |
There was a problem hiding this comment.
Instead of calling the invitation "Chat_Emoji" can we call it something more generic like "Chat_Reaction"
Co-authored-by: celestemartinez <32438984+celestemartinez@users.noreply.github.com>
Co-authored-by: celestemartinez <32438984+celestemartinez@users.noreply.github.com>
Co-authored-by: celestemartinez <32438984+celestemartinez@users.noreply.github.com>
|
@melisabok I think the tests need to be changed too here: |
|
ok, I will change it |
Co-authored-by: carlosmondra <carlos@openreview.net>
|
I tested disabling and enabling the chat via the comment stage and it's working. |
What happens if there are no new comments after 4 hours? Is an email still sent? I also think that it's not necessary to send 1 email every 5 comments. I think that sending 1 email every 4 hours if there are any new messages is enough. |
no emails are sent if there are no new comments since the last_notified_comment_id. |
I'm worried that could be too many messages in 4 hours and the participants won't get any notifications. |
When the comment stage is enabled and the chat interface is enabled for all the selected participants that are members of the reviewing committee: SACs, ACs and reviewers.