Venue and Journal workflows: add invitation id and signature to post_message #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…openreview-py into fix/messages-with-invitation
melisabok
changed the title
melisabok
changed the title
|
I think "note" needs to change to "edit"? This was also changed in recruit_process.py
|
…openreview-py into fix/messages-with-invitation
|
This PR is ready to be reviewed and merged, thanks! |
enrubio
approved these changes
Apr 16, 2024
celestemartinez
approved these changes
Apr 17, 2024
openreview/journal/invitation.py
Outdated
| 'invitees': [ venue_id, self.journal.get_action_editors_id('${3/content/noteNumber/value}')], | ||
| 'message': { | ||
| 'replyTo': { 'param': { 'regex': r'~.*|([a-z0-9_\-\.]{2,}@[a-z0-9_\-\.]{2,}\.[a-z]{2,},){0,}([a-z0-9_\-\.]{2,}@[a-z0-9_\-\.]{2,}\.[a-z]{2,})', 'optional': True } }, | ||
| 'sendAt': { 'param': { 'minimum': 0, 'optional': True } }, |
There was a problem hiding this comment.
Do you use this property at all?
There was a problem hiding this comment.
no, I don't use it, should I remove it?
…openreview-py into fix/messages-with-invitation
carlosmondra
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invitationandsignatureinto the post_message call, these fields are optional to keep backward compatibility