Fix/ Venue: replace note readers #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melisabok
reviewed
Mar 5, 2024
| @@ -108,6 +108,8 @@ def updated_content_readers(note, paper_inv): | |||
| for note in notes: | |||
| final_invitation_readers = list(dict.fromkeys([note.signatures[0] if 'signatures' in r else r for r in invitation_readers])) | |||
| edit_readers = list(dict.fromkeys([note.signatures[0] if 'signatures' in r else r for r in paper_invitation.edit.get('readers',[])])) | |||
| if '${2/note/readers}' in edit_readers: | |||
| edit_readers = final_invitation_readers | |||
There was a problem hiding this comment.
I would use the current note.readers instead of the invitation.note.readers, is there an issue with that?
There was a problem hiding this comment.
the readers of the note could change though, we do this in line 117. If they change, we set them to final_invitation_readers
if final_invitation_readers and note.readers != final_invitation_readers:
updated_note.readers = final_invitation_readers
updated_note.nonreaders = paper_invitation.edit['note'].get('nonreaders')
There was a problem hiding this comment.
can final_invitation_readers be empty?
melisabok
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the edit copies the readers from note.readers, replace this value in
invitation_edit_process.py