Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ Venue: check fields are in content before removing #2042

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

celestemartinez
Copy link
Member

The Submission Revision Stage would give an error if the PCs select authors and authorids in the remove options dropdown and also select Do not allow any changes to author lists.

Now that I think about it, it might be best to just remove authors and authorids from the remove options dropdown and control these two fields solely from the submission_author_edition field. This might be less confusing to PCs.

What do you think, @melisabok , @enrubio ?

Copy link
Member

@melisabok melisabok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

@melisabok melisabok requested a review from enrubio March 8, 2024 15:40
@enrubio enrubio merged commit 26e28b1 into master Mar 11, 2024
1 check passed
@enrubio enrubio deleted the fix/revision-disallow-author-list-edits branch March 11, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants