Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support type 'profile' for authorids #2044

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Conversation

melisabok
Copy link
Member

@melisabok melisabok commented Mar 12, 2024

It depends on https://github.com/openreview/openreview-api/pull/380

This PR is ready to be merged.

@melisabok melisabok changed the title use type profile for authorids, fix tests Support type 'profile' for authorids Mar 12, 2024
@melisabok melisabok marked this pull request as ready for review March 12, 2024 21:03
@carlosmondra carlosmondra merged commit 8ac33b1 into master Mar 13, 2024
1 check passed
@carlosmondra carlosmondra deleted the fix/tests-type-group branch March 13, 2024 16:54
@xkopenreview
Copy link
Contributor

currently type group and group[] are rendered as profile search widget
for this to continue working i will need to change that check to profile and profile[]

does this change mean that type of a field can't be group and group[] any more?
or group and group[] should still be rendered as profile search widget or some other widget?

@melisabok
Copy link
Member Author

it can be both, group or profile. Having profile helps the API to validate the authorids are valid profileids or emails.

This is done to fix the issue when ECCV submitted the papers and use a fake tilde id as authorids.

I do think the UI could validate both types.

@xkopenreview
Copy link
Contributor

so both profile and group will render as profile search widget right?

@melisabok
Copy link
Member Author

so both profile and group will render as profile search widget right?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants