Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paper matching: Check that SAC assignments are deployed before computing AC conflicts #2060

Merged
merged 14 commits into from
Apr 10, 2024
Merged

Paper matching: Check that SAC assignments are deployed before computing AC conflicts #2060

merged 14 commits into from
Apr 10, 2024

Conversation

enrubio
Copy link
Member

@enrubio enrubio commented Mar 27, 2024 •
edited

@melisabok
Copy link
Member

@enrubio you can finish this PR now. There are some conflicts.

@melisabok
Copy link
Member

Any update on this?

@enrubio
Copy link
Member Author

enrubio commented Apr 9, 2024

I didn't get to work on it yesterday, but I can fix it today.

melisabok
melisabok approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@melisabok melisabok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melisabok melisabok merged commit 8656765 into master Apr 10, 2024
1 check passed
@melisabok melisabok deleted the fix/ac-compute-conflicts branch April 10, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melisabok melisabok melisabok approved these changes

@celestemartinez celestemartinez celestemartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paper matching setup: check the SAC assignments are deployed when running the AC setup
3 participants
@enrubio @melisabok @celestemartinez