Fix/ Venue: read review and comment readers from right invitations #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melisabok
approved these changes
Apr 1, 2024
|
There are new changes here: I save the reviewer and AE checklist names in the ARR ethics flag invitation to process these invitations as well in the Ethics_Flag process function. I deleted the ARR specific process function since it's no longer needed. cc @haroldrubio |
celestemartinez
commented
Apr 9, 2024
| invitations=self.venue.get_meta_invitation_id(), | ||
| signatures=[self.venue_id], | ||
| replacement=False, | ||
| invitation=openreview.api.Invitation( |
There was a problem hiding this comment.
I am reposting this invitation every time because I need to add some ARR specific values, but this invitation has no date process so nothing runs.
melisabok
approved these changes
Apr 9, 2024
haroldrubio
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sherry reported an issue when a paper is flagged for Ethics Review. It looks like the we were reading the review readers from the wrong place. I am now reading it from the review invitation itself instead of the ethics flag invitation.