ARR: Fix resubmission bug for fields with only readers #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melisabok
reviewed
Apr 2, 2024
celestemartinez
approved these changes
Apr 2, 2024
melisabok
reviewed
Apr 2, 2024
| "existing_preprints", | ||
| "Association_for_Computational_Linguistics_-_Blind_Submission_License_Agreement", | ||
| "section_2_permission_to_publish_peer_reviewers_content_agreement" | ||
| "section_2_permission_to_publish_peer_reviewers_content_agreement", | ||
| "reviewing_volunteers" |
melisabok
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an extra safety check for fetching resubmissions. There is some behavior with the preprint release invitation that adds readers to optional fields that may not have been in the original submission. The preprint release invitation adds these fields to the submission with only readers and no value.
The resubmission script was just checking for the previous URL to be in the content and then assumes that it has a value, this PR fixes that and also checks for a value