ARR: Fix ethics review tests

[haroldrubio]

This PR sets the ethics review stage to be active in the future instead of activating it as soon as the tests start. This fixes a bug where all submissions had an ethics review invitation created since the ethics review super invitation was active while the submission process functions ran.

Edited to add: I changed the test to start the ethics review stage from the beginning, to make sure no Ethics_Review invitatinos are created since no papers are flagged.

[celestemartinez]

I am a little bit confused about why ethics review invitations were created for all submissions, if it should be created only for flagged submissions? It shouldn't matter when the ethics review super invitation is active.

Edit: I see now why this is happening. Perhaps we should fix this in the submission process as well? Just like how we check if the invitation should be created for accepted submissions only, and if it is, we ignore the invitation:

openreview-py/openreview/venue/process/submission_process.py

Line 82 in 6543c02

accepted_only = ('accepted_submissions' == venue_invitation.content.get('source', {}).get('value', False)) if venue_invitation.content else False

@melisabok what do you think?

[melisabok]

@celestemartinez should we make that change in this PR? Only create invitations for all_submissions source.

[celestemartinez]

@celestemartinez should we make that change in this PR? Only create invitations for all_submissions source.

yes, I can work on this

[celestemartinez]

This should be ready.

[melisabok]

Thanks @celestemartinez! feel free to approve and merge it.