Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/meta review content query #2074

Merged
merged 14 commits into from
Apr 5, 2024
Merged

Conversation

enrubio
Copy link
Member

@enrubio enrubio commented Apr 3, 2024

Adds support for multiple meta review forms by adding source_submissions_query and child_invitations_name to the meta review stage.

Copy link
Member

@melisabok melisabok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@enrubio enrubio marked this pull request as ready for review April 3, 2024 20:00
assert 'metareview' in invitation.edit['note']['content']
assert 'suggestions' not in invitation.edit['note']['content']

invitations = openreview_client.get_invitations(invitation='ICML.cc/2023/Conference/-/Meta_Review_SAC_Revision')
assert len(invitations) == 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't there be 50 Meta_Review_SAC_Revision invitations and 50 Position_Paper_Meta_Review_SAC_Revision invitations?

@celestemartinez celestemartinez merged commit 7a65924 into master Apr 5, 2024
1 check passed
@celestemartinez celestemartinez deleted the fix/meta-review-content-query branch April 5, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants