Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARR: Update Submission and Max Load Fields for April #2076

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

haroldrubio
Copy link
Member

  • Replace field name maximum_load_resubmission with maximum_load_this_cycle_for_resubmissions for the max load request logic
  • Updates the submission fields, and the list of fields to be blinded and hidden from the public on anonymous pre-prints
  • Fixes tests to use updated fields
  • Removes test that requires non-empty reviewing volunteers (this was made optional)
  • Updates test that non-resubmission is not fetched when resubmissions are fetched
    • This is because reassignment_request_reviewers and reassignment_request_action_editor are now required fields, non-resubmissions must select "This is not a resubmission"

"description": "Area-specific keywords. Please provide a comma-separated list of keywords from this page: https://aclrollingreview.org/areas",
"value": {
"param": {
"type": "string",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be string[]?

"yes",
"no",
"n/a"
"This paper has a limitations section."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is the only option and it is not optional, does it mean all the submissions should say "this paper has a limitations section"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, They must select it otherwise it will be desk rejected.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess they just want the authors to have to explicitly check that off

@celestemartinez
Copy link
Member

Should maximum_load be changed to maximum_load_this_cycle? Looks like it was changed in the preprocess and process functions here: https://openreview.net/invitation/edit?id=aclweb.org/ACL/ARR/2024/April/Reviewers/-/Max_Load_And_Unavailability_Request

@haroldrubio
Copy link
Member Author

Thanks for pointing that out, I didn't realize that field changed as well

@celestemartinez
Copy link
Member

It looks like the max_load_preprocess.py was also changed by the PC on the live site?

It is kind of hard to keep track of all the changes they have made.

@celestemartinez celestemartinez merged commit 80456ee into master Apr 3, 2024
1 check passed
@celestemartinez celestemartinez deleted the fix/arr-fields-april-presubmission branch April 3, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants