-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/ Venue: Custom Stage signatures and invitation_edit_process paper number #2088
Conversation
}, | ||
'noteNumber': { | ||
'value': note.number | ||
if isinstance(note, tuple): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fully convinced about checking if the note is a tuple or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could always return a tuple as [note, forumNote] where in the case of submissions they are the same note:
source_submissions = [(n, n) for s in client.get_all_notes(content={ 'venueid': venue_id }, sort='number:asc')]
and when we build the invitation edit content:
{
noteId: forumNote.id,
noteNumber: forumNote.number
}
if 'replyto' in invitation.edit['content']:
content['replyto'] = { 'value': note.id }
....
I think noteId
and noteNumber
should have been called forumId
and forumNumber
but I think it is too late.
Fixes #2083
This PR removes PCs from signatures of the CustomStage and edits how we get the paper number in
invitation_edit_process.py
I am not sure what the best way to get the paper number is when we are deadling with reviews and metareviews, but this is a possible solution.