DBLP import: revert change and throw abstract errors #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
melisabok
commented
Apr 10, 2024
•
melisabok
commented
- Add the readers and writers to the edit that is posted in the process function so authors can see it
- Don't catch the extract abstract errors so we are notified when the cloud function fails.
| } | ||
| } catch (error) { | ||
| console.log('server error: ' + error); | ||
| if (html) { |
There was a problem hiding this comment.
i think the service will be changed to always return json so do we still want the process funtion to fail here
There was a problem hiding this comment.
yes, I want the process function to fail when there is a network error (OpenReviewException)
…nreview-py into fix/throw-abstract-errors
melisabok
changed the title
| @@ -10,10 +10,11 @@ async function process(client, edit, invitation) { | |||
| } | |||
|
|
|||
| const html = note.content.html?.value; | |||
| let abstractError = false; | |||
There was a problem hiding this comment.
i think it will be helpful to log note id in process function
carlosmondra
approved these changes
Apr 12, 2024
xkopenreview
approved these changes
Apr 12, 2024
|
@carlosmondra @xkopenreview this PR should be ready to be merged! |
the invitation in production will need to be updated manually correct? |
|
We need to re-run the ProfileManagenment script, Celeste does it every time she does a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.