Fix/ Submission Revision Stage: update field readers accordingly #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We try to not use replacement=True because that will always post an edit and run the date process function that syncs all the child invitations. Sometimes PCs make some changes that don't affect the child invitations so we don't want to be re-running the expensive date process function. |
melisabok
reviewed
Apr 11, 2024
celestemartinez
changed the title
melisabok
reviewed
Apr 15, 2024
melisabok
reviewed
Apr 15, 2024
celestemartinez
commented
Apr 16, 2024
| for field in content: | ||
| if field in hidden_field_names: | ||
| content[field]['readers'] = [venue_id, self.venue.get_authors_id('${{4/id}/number}')] | ||
| if field not in hidden_field_names and invitation_content.get(field, {}).get('readers', []): |
There was a problem hiding this comment.
@melisabok I reverted back to adding readers to hidden fields. However, I also now check if the invitation exists and if a field has readers that shouldn't be hidden anymore, I remove the readers.
There was a problem hiding this comment.
This would prevent the issue we had with NAACL today.
melisabok
approved these changes
Apr 16, 2024
enrubio
approved these changes
Apr 16, 2024
celestemartinez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
hide_fieldsfrom the Revision invitation and allows to hide fields only using the Post_Submission.This PR also adds all possible content fields to the
hide_fieldsdropdown (we were not adding thesecond_deadline_additional_options)This issue has happened twice, once to MIDL and once to AutoML.I believe what happened was both venues had an abstract deadline, which created the/Revisioninvitations. At somepoint, the pdf was hidden for all submissions. Then the Post Submission was used to unhide the pdfs. Later on, they re-run the Revision stage to allow authors to revise their papers, but they used the default name/Revision. Since pdfs werehidden in these invitations, pdfs started being hidden after authors edited their submission.This PR checks if the field is inhide_fieldsand if it isn't, it removes the readers.**Edit: I have now also noticed that if we usedreplacement=Truewhen posting revision invitations, we would not havethis issue. I am unsure why we sometimes usereplacement=Trueand sometimes we usereplacement=False**