Fix/add test confidential comment #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melisabok
reviewed
Apr 18, 2024
melisabok
reviewed
Apr 24, 2024
melisabok
approved these changes
Apr 24, 2024
| @@ -49,7 +52,7 @@ def process(client, edit, invitation): | |||
| sender=sender, | |||
| recipients=[program_chairs_id], | |||
| ignoreRecipients = ignore_groups, | |||
| subject=f'''[{short_name}] A {invitation_name} has been received on Paper Number: {submission.number}, Paper Title: "{submission.content['title']['value']}"''', | |||
| subject=f'''[{short_name}] {before_invitation} {invitation_name} has been received on Paper Number: {submission.number}, Paper Title: "{submission.content['title']['value']}"''', | |||
| message=f'''We have received a {invitation_name} on a submission to {short_name} for which you are serving as Program Chair. | |||
There was a problem hiding this comment.
Can we use before_invitation in the message text as well?
We have received a author ac confidential comment on a submission to ICML 2023 for which you are an official area chair.
There was a problem hiding this comment.
You're right, I missed that change. Fixed now.
| @@ -152,7 +155,7 @@ def process(client, edit, invitation): | |||
| recipients=submission.content['authorids']['value'], | |||
| ignoreRecipients=ignore_groups, | |||
| replyTo=contact, | |||
| subject=f'''[{short_name}] A {invitation_name} has been received on your Paper Number: {submission.number}, Paper Title: "{submission.content['title']['value']}"''', | |||
| subject=f'''[{short_name}] {before_invitation} {invitation_name} has been received on your Paper Number: {submission.number}, Paper Title: "{submission.content['title']['value']}"''', | |||
| message=f'''We have recieved a {invitation_name} on your submission to {short_name} | |||
There was a problem hiding this comment.
Suggested change
| message=f'''We have recieved a {invitation_name} on your submission to {short_name} | |
| message=f'''We have received a {invitation_name} on your submission to {short_name}. |
There was a problem hiding this comment.
please include a test for the message content.
celestemartinez
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for Author-AC confidential comments.