Venue: add bid invitation to assignment configuration #2111
Conversation
openreview/venue/invitation.py
Outdated
| scores_spec['value']['param']['default'][bid_invitation.id] = { | ||
| 'weight': 1, | ||
| 'default': 0, | ||
| 'translate_map' : { |
There was a problem hiding this comment.
The changes look good, I think we should store this mapping function somewhere so it is not repeated in the code.
What about storing it in the Bid Invitation content and then read it to set the score spec?
| 'Very Low': -1.0 | ||
| } | ||
| } | ||
| score_spec[invitation.id] = invitation.content['scores_spec']['value'] |
There was a problem hiding this comment.
@melisabok I am worried any already created invitations would not have this value and this would give an error, and setting a default would mean we still have duplicated code.
There was a problem hiding this comment.
@melisabok what do you think about this? I wonder the same thing, but it may not be a big issue if bidding isn't commonly used
There was a problem hiding this comment.
We can leave this as it its, I didn't want to hav the translate_map duplicated in the code, that is why I suggested to store it in the invitation.content.
Sometimes a venue may want to use a different scale or bid labels so it would be nice this can be configure by themselves.
Fixes #2079