Venue: let PCs undeploy assignments #2116
Conversation
melisabok
commented
Apr 26, 2024
melisabok
commented
- New unset_assignment method.
- Make sure we use the review and meta review names instead of hardcoded names.
- Fix validation to set and unset assignments when there are already reviews/metareviews posted.
- Add tests
- Remove commented code
openreview/venue/matching.py
Outdated
|
|
||
| ## Undeploy assignments | ||
| if self.is_senior_area_chair and not self.venue.sac_paper_assignments: | ||
| self.undeploy_sac_assignments() |
There was a problem hiding this comment.
Has this been implemented already? I can't find it
There was a problem hiding this comment.
oops, I forgot it!
I think in this case it is only deleting the assignments edges?
There was a problem hiding this comment.
Correct! About changing the status of the configuration, will this be done in the matcher code?
There was a problem hiding this comment.
yes, I need to create a PR in openreview-matcher and openreview-web to enable this from the UI
|
UPDATE: I changed the strategy to undeploy the assignments related to the configuration title instead of removing all the assignments. This way we can deploy multiple assignments from the UI. |
|
@celestemartinez this PR is ready to be reviewed again, thanks! |
| content = {} | ||
| if 'assigned_action_editor' in note.content: | ||
| if note.content['venueid']['value'] == journal.under_review_venue_id: |
There was a problem hiding this comment.
Will an AE be added to the submission only when the venueid == journal.under_review_venue_id? Could the venue id be journal.assigning_AE_venue_id instead and need the assigned_action_editor added?
There was a problem hiding this comment.
usually assigned_action_editor is being set when the paper is under review.
I'm handling this case when the AE is unassigned and then another one is assigned when the paper is under review.
There was a problem hiding this comment.
BTW I will make a new PR where the assigned_action_editor will be visible as soon as the AE is assigned.
|
We don't need to do anything about the |
|
That's true, I didn't change the invite invitation. |
