Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARR: Load custom PC webfield #2121

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

haroldrubio
Copy link
Member

Depends on openreview/openreview-web#1897

This PR adds the submissionContentFields for papers flagged for desk reject verification. The tests set the flags on the tested submission to be false.

To flag a submission, submit an action editor or reviewer checklist and refer to the webfield to see what fields should be set to what value to make it flagged (ie setting Anonymity to "No")

You can make a desk reject verification reply to that submission's forum to test how it renders in the new tab

@haroldrubio haroldrubio self-assigned this May 2, 2024
@zbialecki
Copy link
Contributor

zbialecki commented May 2, 2024

I'm getting the error Unhandled Runtime Error. TypeError: Cannot use 'in' operator to search for 'options' in undefined when I try to filter the Paper Status tab. Steps:

Using openreview-py test data:

You should see the error. I don't see it in any of the other tabs.

@melisabok
Copy link
Member

I can reproduce the same issue, it seems to be related to the select widget, I'm not sure if the new tab is overriding some settings.

@haroldrubio
Copy link
Member Author

I found the error in how I was adding the content field to the sort options, I pushed a fix in web if you could take a look and review it

@melisabok melisabok merged commit 93d9b4e into master May 6, 2024
1 check passed
@melisabok melisabok deleted the feature/arr-new-paper-status branch May 6, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants