Venue request: avoid same stage to run twice and post a comment when the stage is complete #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melisabok
changed the title
celestemartinez
approved these changes
May 7, 2024
enrubio
approved these changes
May 7, 2024
melisabok
commented
May 7, 2024
| @@ -624,6 +624,23 @@ def process(client, note, invitation): | |||
| client.post_invitation(submission_revision_invitation) | |||
|
|
|||
| print('Conference: ', conference.get_id()) | |||
| comment_note = openreview.Note( | |||
There was a problem hiding this comment.
@racheljsmart this code must be in the process function of your venue request invitations.
There was a problem hiding this comment.
Maybe the comment could read "The {invitation_type.replace("_", " ")} process has been completed." ?
Currently "The process for the {invitation_type.replace("_", " ")} process has been completed." is a little redundant.
racheljsmart
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid API error
Could not remove job ...and post a comment then the job is complete to give more information to the PCs.