Merge pull request #1550 from SiboVG/issue-1549

[#1549] Ctrl/Cmd + A select all shortcut in simulation table and component tree

swing/src/net/sf/openrocket/gui/main/BasicFrame.java

@@ -418,18 +418,18 @@ public void valueChanged(TreeSelectionEvent e) {
 		button = new SelectColorButton(actions.getMoveDownAction());
 		panel.add(button, "sizegroup buttons, aligny 0%");
 
-		button = new SelectColorButton(actions.getEditAction());
-		button.setIcon(null);
+		button = new SelectColorButton();
+		RocketActions.tieActionToButtonNoIcon(button, actions.getEditAction());
 		button.setMnemonic(0);
 		panel.add(button, "sizegroup buttons, gaptop 20%");
 
-		button = new SelectColorButton(actions.getDuplicateAction());
-		button.setIcon(null);
+		button = new SelectColorButton();
+		RocketActions.tieActionToButtonNoIcon(button, actions.getDuplicateAction());
 		button.setMnemonic(0);
 		panel.add(button, "sizegroup buttons");
 
-		button = new SelectColorButton(actions.getDeleteAction());
-		button.setIcon(null);
+		button = new SelectColorButton();
+		RocketActions.tieActionToButtonNoIcon(button, actions.getDeleteAction());
 		button.setMnemonic(0);
 		panel.add(button, "sizegroup buttons");
 

swing/src/net/sf/openrocket/gui/main/RocketActions.java

@@ -12,6 +12,7 @@
 
 import javax.swing.AbstractAction;
 import javax.swing.Action;
+import javax.swing.JButton;
 import javax.swing.JCheckBox;
 import javax.swing.JOptionPane;
 import javax.swing.JPanel;
@@ -189,6 +190,35 @@ public Action getMoveDownAction() {
 		return moveDownAction;
 	}
 
+	/**
+	 * Tie an action to a JButton, without using the icon or text of the action for the button.
+	 *
+	 * For any smartass that wants to know why you don't just initialize the JButton with the action and then set the
+	 * icon to null and set the button text: this causes a bug where the text of the icon becomes much smaller than is intended.
+	 *
+	 * @param button button to tie the action to
+	 * @param action action to tie to the button
+	 * @param text text to display on the button
+	 */
+	public static void tieActionToButtonNoIcon(JButton button, Action action, String text) {
+		button.setAction(action);
+		button.setIcon(null);
+		button.setText(text);
+	}
+
+	/**
+	 * Tie an action to a JButton, without using the icon of the action for the button.
+	 *
+	 * For any smartass that wants to know why you don't just initialize the JButton with the action and then set the
+	 * icon to null: this causes a bug where the text of the icon becomes much smaller than is intended.
+	 *
+	 * @param button button to tie the action to
+	 * @param action action to tie to the button
+	 */
+	public static void tieActionToButtonNoIcon(JButton button, Action action) {
+		button.setAction(action);
+		button.setIcon(null);
+	}
 
 
 	////////  Helper methods for the actions