Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] "Export as" "Export simulation table as CSV file" menu options incorrect: should be "Export as...", etc. #2445

Closed
jimmiedave opened this issue Jan 26, 2024 · 0 comments · Fixed by #2459
Labels

Comments

@jimmiedave
Copy link
Contributor

jimmiedave commented Jan 26, 2024

Describe the bug

Menu language generally interprets an ellipsis ("...") after a menu entry to mean that there's a following dialog or sheet, rather than immediate action.

In OpenRocket, we can see the correctly presented "New" (which immediately creates a new doc), and "Open..." (which opens a dialog allowing user to select a doc to open).

"Export as" implies immediate action upon its selection, while "Export as..." implies there's a following dialog box, which, in the case of OpenRocket, there is.

In OR there is the choice of file format presented in the "Export as" menu, but this does not obviate the Export dialog appearance, and it'd be kind of weird to follow the file formats with ellipses.

To Reproduce

  1. Select "Export as" from the "File" menu.
  2. Choose a format (.rkt or .CDX1, or Wavefront .OBJ, if a prior part selection has been made)
  3. Note appearance of a dialog box.

"Export simulation table as CSV file" same issue, simpler repro: select "Export simulation table as CSV file" menu item, note dialog.
...

Screenshots / .ork file

Screenshot(s):

(drag-and-drop the screenshot(s) here)

Screenshot 2024-01-25 at 7 15 11 PM Screenshot 2024-01-25 at 7 15 21 PM

.ork file:

(drag-and-drop the file here as a .zip file)

OpenRocket version

23.09

What platform are you running on?

macOS

Additional context

No response

@jimmiedave jimmiedave added the bug label Jan 26, 2024
@jimmiedave jimmiedave changed the title [Bug] "Export as" menu option incorrect: should be "Export as..." [Bug] "Export as" "Export simulation table as CSV file" menus option incorrect: should be "Export as...", etc. Jan 26, 2024
@jimmiedave jimmiedave changed the title [Bug] "Export as" "Export simulation table as CSV file" menus option incorrect: should be "Export as...", etc. [Bug] "Export as" "Export simulation table as CSV file" menu options incorrect: should be "Export as...", etc. Jan 26, 2024
SiboVG added a commit to SiboVG/openrocket that referenced this issue Feb 14, 2024
JoePfeiffer added a commit that referenced this issue Feb 16, 2024
[#2445] Add ellipsis to export as in file menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant