-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP is still off-center if pods. #654
Comments
Just clarified the title -- the display isn't the problem (in fact, was masking the problem). |
Ah. The CP code for FinSets recognizes when there are three or more fins in the set, and (because they're evenly distributed around the axis) pins CP Y and Z to 0. This doesn't work when there are pods, since there may be only a single fin on the pod, even though the pods are evenly distributed. Need to look more closely at the moment calculations... |
@JoePfeiffer I'm assumed you're referencing #568? |
I just ran the 3fnc files referenced above through our Closing as resolved. |
I wasn't specifically referencing any other issue in particular, though the examples in #568 are a good test case. Yes, this issue is resolved. |
In Neil's 3fnc test rockets, CP is still shown off-center in 3fnc-take2-pods.ork. On-center in 3fnc-take2.ork, however.
The text was updated successfully, but these errors were encountered: