Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP is still off-center if pods. #654

Closed
JoePfeiffer opened this issue May 6, 2020 · 5 comments
Closed

CP is still off-center if pods. #654

JoePfeiffer opened this issue May 6, 2020 · 5 comments
Assignees

Comments

@JoePfeiffer
Copy link
Contributor

In Neil's 3fnc test rockets, CP is still shown off-center in 3fnc-take2-pods.ork. On-center in 3fnc-take2.ork, however.

@JoePfeiffer JoePfeiffer changed the title CP is still shown off-center in 3D views if pods. CP is still off-center if pods. May 6, 2020
@JoePfeiffer
Copy link
Contributor Author

Just clarified the title -- the display isn't the problem (in fact, was masking the problem).

@JoePfeiffer
Copy link
Contributor Author

Ah. The CP code for FinSets recognizes when there are three or more fins in the set, and (because they're evenly distributed around the axis) pins CP Y and Z to 0. This doesn't work when there are pods, since there may be only a single fin on the pod, even though the pods are evenly distributed.

Need to look more closely at the moment calculations...

@JoePfeiffer JoePfeiffer self-assigned this May 6, 2020
@teyrana
Copy link
Member

teyrana commented May 9, 2020

@JoePfeiffer I'm assumed you're referencing #568?

@teyrana
Copy link
Member

teyrana commented May 9, 2020

I just ran the 3fnc files referenced above through our unstable branch, and the CP is on-axis.
It looks like this was resolved by PR #657.

Closing as resolved.

@teyrana teyrana closed this as completed May 9, 2020
@JoePfeiffer
Copy link
Contributor Author

JoePfeiffer commented May 9, 2020

I wasn't specifically referencing any other issue in particular, though the examples in #568 are a good test case. Yes, this issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants