Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] 2D Rocket Figure will now display off-axis CoM and CoP #655

Merged
merged 2 commits into from
May 8, 2020

Conversation

teyrana
Copy link
Member

@teyrana teyrana commented May 6, 2020

This does NOT affect any calculations -- it just more accurately displays those same values on the 2D view.

This also means that 2d views and 3d views display these values more similarly.

@teyrana teyrana requested review from JoePfeiffer and wolsen May 6, 2020 19:30
@teyrana teyrana self-assigned this May 6, 2020
@teyrana
Copy link
Member Author

teyrana commented May 6, 2020

( Spin off from #641, #654 )

@TravisBuddy
Copy link

Hey @teyrana,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 6d05d610-8fd0-11ea-a26d-2bd2cd942036

@JoePfeiffer
Copy link
Contributor

I think you're right, we need to do this -- we may decide to pin the CP to Y=Z=0 in some (most?) cases, but the figures need to show whatever we end up calculating.

But, in 2D view, as I rotate the rocket the CP stays stationary instead of rotating with the rocket.

@teyrana teyrana mentioned this pull request May 7, 2020
@teyrana teyrana marked this pull request as draft May 7, 2020 20:41
@JoePfeiffer
Copy link
Contributor

This isn't rotating the CP with the rocket -- with the attached design (which is the off-axis CP example I created before with the nose cone removed so the CP is really off axis) the CP just sits at the top of the body tube as the rocket is rotated.
two-fins.ork.zip

@teyrana
Copy link
Member Author

teyrana commented May 7, 2020

(display now respects the rotation slider)

@TravisBuddy
Copy link

Hey @teyrana,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d731a0f0-90ac-11ea-ba10-7b1b65697aa0

@JoePfeiffer
Copy link
Contributor

That's got it. My vote is we merge this so we actually see what we're calculating (whatever that turns out to be).

@teyrana teyrana marked this pull request as ready for review May 8, 2020 15:02
@teyrana teyrana merged commit deed818 into openrocket:unstable May 8, 2020
@teyrana teyrana deleted the show-cp-y branch May 8, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants