Fix NaN occuring in simulations.

[kruland2607]

Fix NaN occurring in computation of CGx and CGy of fin sets due to botched test for 0 denominators.

[plaa]

Please split these up into separate test cases. There's no reason to have then in one method, as they're clearly separate. E.g. testCGTriangularFin, testCGRectangularFin etc. The test case name should also explain what the test contains, it's hard to deduce from the numbers themselves.

[kruland2607]

Agreed - will do.

On 10/6/2012 9:15 AM, plaa wrote:

In core/test/net/sf/openrocket/rocketcomponent/FinSetTest.java:

import net.sf.openrocket.util.LineStyle;
import net.sf.openrocket.util.BaseTestCase.BaseTestCase;

import org.junit.Test;

public class FinSetTest extends BaseTestCase {

• @test
• public void testCGComputation() throws Exception {

Please split these up into separate test cases. There's no reason to
have then in one method, as they're clearly separate. E.g.
testCGTriangularFin, testCGRectangularFin etc. The test case name
should also explain what the test contains, it's hard to deduce from
the numbers themselves.

—
Reply to this email directly or view it on GitHub
https://github.com/plaa/openrocket/pull/3/files#r1779419.