Skip to content

Commit

Permalink
Renamed Visitor to SettingsVisitor to avoid naming confusion
Browse files Browse the repository at this point in the history
  • Loading branch information
kintel committed Jun 13, 2016
1 parent 7800683 commit 9f89991
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions src/Preferences.cc
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Preferences *Preferences::instance = NULL;
const char * Preferences::featurePropertyName = "FeatureProperty";
Q_DECLARE_METATYPE(Feature *);

class SettingsReader : public Settings::Visitor
class SettingsReader : public Settings::SettingsVisitor
{
QSettings settings;
Value getValue(const Settings::SettingsEntry& entry, const std::string& value) const {
Expand Down Expand Up @@ -90,7 +90,7 @@ class SettingsReader : public Settings::Visitor
}
};

class SettingsWriter : public Settings::Visitor
class SettingsWriter : public Settings::SettingsVisitor
{
virtual void handle(Settings::SettingsEntry& entry) const {
Settings::Settings *s = Settings::Settings::inst();
Expand Down
6 changes: 3 additions & 3 deletions src/settings.cc
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ Settings::~Settings()
{
}

void Settings::visit(Visitor& visitor)
void Settings::visit(SettingsVisitor& visitor)
{
for (std::list<SettingsEntry *>::iterator it = entries.begin();it != entries.end();it++) {
visitor.handle(*(*it));
Expand All @@ -109,11 +109,11 @@ void Settings::set(SettingsEntry& entry, const Value &val)
entry._value = val;
}

Visitor::Visitor()
SettingsVisitor::SettingsVisitor()
{
}

Visitor::~Visitor()
SettingsVisitor::~SettingsVisitor()
{
}

Expand Down
8 changes: 4 additions & 4 deletions src/settings.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class Settings

static Settings *inst(bool erase = false);

void visit(class Visitor& visitor);
void visit(class SettingsVisitor& visitor);

const Value &defaultValue(const SettingsEntry& entry);
const Value &get(const SettingsEntry& entry);
Expand All @@ -66,11 +66,11 @@ class Settings
virtual ~Settings();
};

class Visitor
class SettingsVisitor
{
public:
Visitor();
virtual ~Visitor();
SettingsVisitor();
virtual ~SettingsVisitor();

virtual void handle(SettingsEntry& entry) const = 0;
};
Expand Down

0 comments on commit 9f89991

Please sign in to comment.