Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use search order fix #3196

Merged
merged 3 commits into from
Feb 2, 2020
Merged

Use search order fix #3196

merged 3 commits into from
Feb 2, 2020

Conversation

nophead
Copy link
Member

@nophead nophead commented Jan 25, 2020

Searches for module and functions in used files are now in reverse order of use. This ensures later uses override earlier ones when they define the same name.

kintel
kintel approved these changes Feb 2, 2020
View reviewed changes
Copy link
Member

@kintel kintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me like this nondeterministic behavior has been there pretty much since the start.
Thanks for the fix!

@kintel kintel merged commit 854582a into openscad:master Feb 2, 2020
@nophead nophead deleted the use-search-order-fix branch February 2, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kintel kintel kintel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nophead @kintel