Correct use of "-nightly" icons suffix for snapshots builds #4488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehans
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
LGTM.
It see now what you meant about there being two orthogonal concepts.
The remaining usages of SUFFIX_WITH_DASH are for basically naming the executable and directory names, etc.
While SNAPSHOT_SUFFIX is specifically for selecting "nightly" alternate icons and images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some mixup in how the CMake
-DSUFFIXand-DSNAPSHOTparameters were used to determine executable name, install location and icon name.This change makes all builds with
-DSNAPSHOTuse the "-nightly" version of icons, but otherwise doesn't interfere with how-DSUFFIXis managed.Tested on macOS, could use some testing on other platforms.