Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numpy.float deprecated but still used by the cicero-scm #81

Closed
jkikstra opened this issue Feb 12, 2023 · 3 comments
Closed

numpy.float deprecated but still used by the cicero-scm #81

jkikstra opened this issue Feb 12, 2023 · 3 comments

Comments

@jkikstra
Copy link
Contributor

Describe the bug

The cicero-scm workflow test started failing since numpy has been updated to 1.21+, which has deprecated np.float for the builtin float.

See: iiasa/climate-assessment#26

After a quick look, it seems like this line may be the single offender:

openscm-runner/src/openscm_runner/adapters/utils/cicero_utils/make_scenario_common.py

Line 228 in b4c6fa0

np.float

This was referenced Feb 12, 2023
Merged
Merged
jkikstra added a commit to iiasa/climate-assessment that referenced this issue Feb 12, 2023
@jkikstra
Restrict numpy version until cicero is updated on openscm-runner
935f380 
openscm/openscm-runner#81
@maritsandstad
Copy link
Collaborator

I'll look at and fix the ciceroscm usage today...

@maritsandstad
Copy link
Collaborator

Sorry, it seems you already fixed this...?

@jkikstra
Copy link
Contributor Author

jkikstra commented Feb 13, 2023 •
edited
Loading

Hi @maritsandstad thanks - yes @lewisjared has merged it with #82 and updated it to the changelog!

So this one can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maritsandstad @jkikstra