New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests of compatibility #162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znicholls
force-pushed
the
add-tests-of-compatibility
branch
from
October 19, 2018 10:43
ba5a5ea
to
12e9580
Compare
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 96.76% 96.99% +0.23%
==========================================
Files 5 5
Lines 1142 1165 +23
Branches 177 183 +6
==========================================
+ Hits 1105 1130 +25
+ Misses 20 19 -1
+ Partials 17 16 -1
Continue to review full report at Codecov.
|
znicholls
force-pushed
the
add-tests-of-compatibility
branch
from
October 19, 2018 12:43
026f32e
to
03f75e9
Compare
znicholls
force-pushed
the
add-tests-of-compatibility
branch
from
October 19, 2018 14:22
f43e126
to
5e82bc9
Compare
this should be merged after #163 due to the SCEN renaming done there |
Tidy up and update CHANGELOG
znicholls
force-pushed
the
add-tests-of-compatibility
branch
from
October 19, 2018 20:54
f750442
to
3cf857f
Compare
@rgieseke all yours |
rgieseke
requested changes
Oct 21, 2018
rgieseke
approved these changes
Oct 22, 2018
rgieseke
approved these changes
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rst
addedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following:
closes #95 (inadequately but it's a start we can fill out later)