Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests of compatibility #162

Merged
merged 9 commits into from Oct 22, 2018
Merged

Add tests of compatibility #162

merged 9 commits into from Oct 22, 2018

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Oct 19, 2018

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

closes #95 (inadequately but it's a start we can fill out later)

@codecov-io
Copy link

codecov-io commented Oct 19, 2018

Codecov Report

Merging #162 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   96.76%   96.99%   +0.23%     
==========================================
  Files           5        5              
  Lines        1142     1165      +23     
  Branches      177      183       +6     
==========================================
+ Hits         1105     1130      +25     
+ Misses         20       19       -1     
+ Partials       17       16       -1
Impacted Files Coverage Δ
pymagicc/definitions/__init__.py 98.48% <100%> (+0.03%) ⬆️
pymagicc/io.py 97.12% <100%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ec4d4...6cdbf73. Read the comment docs.

@znicholls znicholls changed the title Add tests of compatibility WIP: Add tests of compatibility Oct 19, 2018
@znicholls
Copy link
Collaborator Author

this should be merged after #163 due to the SCEN renaming done there

@znicholls znicholls changed the title WIP: Add tests of compatibility Add tests of compatibility Oct 19, 2018
@znicholls
Copy link
Collaborator Author

@rgieseke all yours

@znicholls znicholls mentioned this pull request Oct 21, 2018
4 tasks
pymagicc/io.py Show resolved Hide resolved
scripts/read_write_scen.py Outdated Show resolved Hide resolved
@rgieseke rgieseke merged commit d620a1d into master Oct 22, 2018
@rgieseke rgieseke deleted the add-tests-of-compatibility branch October 22, 2018 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests that pymagicc written files are compatible with MAGICC
3 participants