156 hfc 245

[znicholls]

Pull request

Please confirm that this pull request has done the following:

• Tests added
• Documentation added (where applicable)
• Example added (either to an existing notebook or as a new notebook, where applicable)
• Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

closes #156

[rgieseke]

Seems a useful change and clarification!

[znicholls]

it's more complicated than I thought, give me an hour

[znicholls]

ok @rgieseke all yours (checks pending)

[codecov-io]

Codecov Report

Merging #163 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   96.73%   96.76%   +0.02%     
==========================================
  Files           5        5              
  Lines        1132     1142      +10     
  Branches      174      177       +3     
==========================================
+ Hits         1095     1105      +10     
  Misses         20       20              
  Partials       17       17

Impacted Files	Coverage Δ
pymagicc/definitions/__init__.py	98.44% <100%> (+0.13%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2acaec1...1b91ec4. Read the comment docs.

[rgieseke]

Just a question, the new way is without Hyphen, because we want that later anyway?

[znicholls]

OpenSCM without hyphen based on our conversation the other day where you said it would be better to avoid hyphens in variable names where possible (although we also have spaces eg 'magicc afolu' so maybe that's a waste of time and consistency with whatever pyam does is more important). MAGICC7 without hyphen and all uppercase because having hyphens in fortran is asking for trouble and because fortran is case insensitive and all uppercase makes it more obvious.

…

On Fri, 19 Oct 2018 at 5:26 pm, Robert Gieseke ***@***.***> wrote: Just a question, the new way is without Hyphen, because we want that later anyway? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#163 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWh-m4DtLyoDkfK_z8_2T1mP6f0jGEDtks5ume8ZgaJpZM4XwJNl> .

[rgieseke]

Always trade-offs :-)
In general, I prefer simple usability as Pandas DataFrames columns (no spaces, no hyphens), but it can be useful to stay consistent with other variable names. The current one is fine though!