Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.5 support #20

Merged
merged 5 commits into from
Dec 17, 2019
Merged

Add python 3.5 support #20

merged 5 commits into from
Dec 17, 2019

Conversation

lewisjared
Copy link
Collaborator

Fixes #18

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #20 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   98.83%   98.82%   -0.02%     
==========================================
  Files           7        7              
  Lines         775      767       -8     
  Branches      152      152              
==========================================
- Hits          766      758       -8     
  Misses          9        9
Impacted Files Coverage Δ
src/scmdata/time.py 100% <ø> (ø) ⬆️
src/scmdata/units.py 100% <100%> (ø) ⬆️
src/scmdata/dataframe.py 99.74% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fc3ff1...09d81d0. Read the comment docs.

Copy link
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duck typing for life

@lewisjared lewisjared merged commit 71b623f into master Dec 17, 2019
@lewisjared lewisjared deleted the py35 branch December 17, 2019 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid syntax in line 36 of dataframe.py (python 3.5)
2 participants