Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netCDF support V2 #34

Merged
merged 20 commits into from
Apr 16, 2020
Merged

Add netCDF support V2 #34

merged 20 commits into from
Apr 16, 2020

Conversation

lewisjared
Copy link
Collaborator

@lewisjared lewisjared commented Apr 9, 2020

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/openscm/scmdata/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/openscm/scmdata/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/openscm/scmdata/issues/YY>`_)

Requires:

Supercedes #26

Closes #15

@codecov-io
Copy link

codecov-io commented Apr 9, 2020

Codecov Report

Merging #34 into master will decrease coverage by 2.51%.
The diff coverage is 72.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   94.29%   91.77%   -2.52%     
==========================================
  Files          11       12       +1     
  Lines        1315     1484     +169     
  Branches      281      318      +37     
==========================================
+ Hits         1240     1362     +122     
- Misses         50       89      +39     
- Partials       25       33       +8     
Impacted Files Coverage Δ
src/scmdata/netcdf.py 69.23% <69.23%> (ø)
src/scmdata/run.py 92.64% <75.00%> (+0.03%) ⬆️
src/scmdata/__init__.py 100.00% <100.00%> (ø)
src/scmdata/dataframe.py 96.53% <100.00%> (+0.07%) ⬆️
src/scmdata/testing.py 100.00% <100.00%> (ø)
src/scmdata/groupby.py 86.20% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804d9ee...34737f2. Read the comment docs.

@znicholls
Copy link
Collaborator

If we want other reviewers, we could always ping IAMconsortium/pyam#335

src/scmdata/netcdf.py Outdated Show resolved Hide resolved
src/scmdata/netcdf.py Outdated Show resolved Hide resolved
src/scmdata/netcdf.py Outdated Show resolved Hide resolved
src/scmdata/netcdf.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
src/scmdata/testing.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge @lewisjared this looks great!

@znicholls znicholls deleted the run-netcdf branch April 16, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hdf5 format
3 participants