Adding maintainers to opensearch-project.

[dblock]

Signed-off-by: dblock dblock@amazon.com

Description

I'd like to propose a lightweight process for adding maintainers to opensearch-project repos.

Note that the 3 positive votes and no vetoes comes from Apache.

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[peternied]

I really like the Emeritus notion and blend of public / private discussion.

[dblock]

Tagging those listed in MAINTAINERS.md today for feedback please!

@abbashus, @abhinavGupta16, @adnapibar, @akbhatta, @alolita, @AmiStrn, @ananzh, @anasalkouz, @Andross, @anirudha, @asifsmohammed, @bbarani, @boktorbb-amzn, @bowenlan-amzn, @CEHENKLE, @chenqi0805, @chloe-zh, @cliu123, @cmanning09, @dai-chen, @DandyDeveloper, @dapowers87, @DarshitChanpura, @davidcui-amzn, @davidcui1225, @davidlago, @dbbaughe, @dinujoh, @dlvenable, @elfisher, @eugenesk24, @example, @gaiksaya, @getsaurabh02, @graytaylor0, @guiangumpac, @harold-wang, @itiyamas, @jmazanec15, @jngz-es, @joshuali925, @jotok, @kaituo, @kartg, @kavilla, @kavithacm, @kkhatua, @krishna-ggk, @leeyun-amzn, @lezzago, @mch2, @meghasaik, @mengweieric, @mihirsoni, @nknize, @ohltyler, @ohtyler, @owaiskazi19, @paulborgermans, @penghuo, @peternied, @peterzhuamazon, @praveensameneni, @ps48, @qreshi, @reta, @rguo-aws, @rishabhmaurya, @Rishikesh1159, @ryanbogan, @saratvemulapalli, @sbayer55, @seanneumann, @setiah, @shwetathareja, @skkosuri-amzn, @sruti1312, @sshivanii, @stockholmux, @thalurur, @TheAlgo, @tlfeng, @tmarkley, @treddeni-amazon, @VachaShah, @vamshin, @vengadanathan-s, @VijayanB, @wnbts, @xuezhou25, @yizheliu-amazon, @ylwu-amzn, @yujias0706, @Yury-Fridlyand, @zelinh, @zhanghg08, @zhongnansu @saravanan30erd

[DandyDeveloper]

I'm all for this. I have periods of inactivity, so having someone reaching out to reinvigorate or remind me of the responsibilities I have works.

Having a process that helps us get more people on board more consistently is always good.

I don't have any direct changes I'd make to what is outlined but it would be good to keep an open mind in continuously improving this process as we move forward

[AmiStrn]

Finally! Thanks @dblock for putting this together, it is great to see this positive process start to happen.

[TheAlgo]

Big Thanks @dblock for putting this up. This move will definitely improve the engagement and it would improve the efficiency of review and release 🥇

[dblock]

I don't have any direct changes I'd make to what is outlined but it would be good to keep an open mind in continuously improving this process as we move forward

Thanks for calling this out. I think a note about maintainers improving processes, in general, would be a good idea - would you like to suggest a specific edit?

[jkowall]

I'm glad the governance discussion is moving forward with this change. From looking at the https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md it seems like the maintainers don't do anything regarding CI, releases, or other aspects of releasing and building the software. Is that always going to remain an Amazon responsibility? In other projects I work on and maintain, we have all the obligations spread among the maintainers.

Thanks @dblock !

[dblock]

From looking at the https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md it seems like the maintainers don't do anything regarding CI, releases, or other aspects of releasing and building the software. Is that always going to remain an Amazon responsibility? In other projects I work on and maintain, we have all the obligations spread among the maintainers.

We have a few sections: "Overall Health of the Repo", a small section on "Continuous Integration Checks" and "Release Frequently". For a general purpose MAINTAINERS we don't want to be too prescriptive about what that means, but definitely CI and releases are part of the maintainer responsibility. Would you like to expand those sections along those lines? (I fixed the typo in continuous.)

Amazon took on building, testing and releasing many of the bits (e.g. Linux distribution, clients), which manifests itself mostly in https://github.com/opensearch-project/opensearch-build, currently only maintained by Amazonians (but more welcome!), and has the advantage of using tons of AWS hardware, and being signed. Note that Amazon isn't releasing, for example, a FreeBSD distribution, which is entirely supported by the community. So definitely not something Amazon wants to be responsible for fully and would be happy for the community to step in where it wants to.

[DandyDeveloper]

I don't have any direct changes I'd make to what is outlined but it would be good to keep an open mind in continuously improving this process as we move forward

Thanks for calling this out. I think a note about maintainers improving processes, in general, would be a good idea - would you like to suggest a specific edit?

I actually don't at the moment. I think any start is a great start @dblock

[stockholmux]

I like the spirit of the document, I think there are holes though.

[elfisher]

@dblock this probably isn't the right doc, but this made me think we should probably update .MAINTAINERS (or something else) to clarify mechanics for adding features to the roadmap. We have an FAQ which says "the maintainers of the repo will also work with you to incorporate it into the roadmap." However, it isn't super clear how this works in MAINTAINERS.md. let me know your thoughts. I can create a separate issue for this.

[nknize]

This revision LGTM.

Let this serve as a 24 hour merge notification. If no vetoes are received in the next 24 hours we will merge without prejudice.

[mikemccand]

Looks great! Thanks @dblock and everyone for the exciting discussion. I'm looking forward to strong growth in OpenSearch maintainers going forwards!

[nknize]

🎉 🎈 🥳 LGTM! Let's get the community rolling!

[nknize]

Let's give a final 24 hour notice to allow all time zones a chance to review latest changes?

[peternied]

@nknize - I like that idea. Assuming no additional feedback, after the 24hr window has passed would you be willing to merge?

[anirudha]

is someone waiting on something to merge this or can we just click "Merge" and celebrate ?

[peternied]

is someone waiting on something to merge this or can we just click "Merge" and celebrate ?

@anirudha A large number of contributors to this PR do not have approval/request changes permissions, this delay provides an opportunity to check on the changes and provide comments before its merged.

[nknize]

Assuming no additional feedback, after the 24hr window has passed would you be willing to merge?

Absolutely!

[nknize]

The vote has passed and the process is merged!

Congratulations OpenSearch-Project! This is a milestone day! 🎉 We can't thank the community enough for all of the productive discussion and valuable contribution. What a sign of things to come!