Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PURIFY] Removes Newsfeed plugin button and feed (#10) #15

Merged
merged 3 commits into from
Feb 4, 2021
Merged

[PURIFY] Removes Newsfeed plugin button and feed (#10) #15

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d25f9a
[PURIFY] Removes Newsfeed plugin button and feed (#10)
Feb 4, 2021
5dae123
Removes elastic endpoints from newfeed plugin code
Feb 4, 2021
639220e
Remove elastic endpoints, remove kibana manifest file for newsfeed, s…
Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/plugins/kibana_overview/kibana.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"server": false,
"ui": true,
"requiredPlugins": ["navigation", "data", "home"],
"optionalPlugins": ["newsfeed"],
"requiredBundles": ["kibanaReact", "newsfeed"]
"optionalPlugins": [],
"requiredBundles": ["kibanaReact"]
}
4 changes: 2 additions & 2 deletions src/plugins/newsfeed/common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ export const NEWSFEED_FALLBACK_MAIN_INTERVAL = 120000; // 2 minutes
export const NEWSFEED_LAST_FETCH_STORAGE_KEY = 'newsfeed.lastfetchtime';
export const NEWSFEED_HASH_SET_STORAGE_KEY = 'newsfeed.hashes';

export const NEWSFEED_DEFAULT_SERVICE_BASE_URL = 'https://feeds.elastic.co';
export const NEWSFEED_DEV_SERVICE_BASE_URL = 'https://feeds-staging.elastic.co';
export const NEWSFEED_DEFAULT_SERVICE_BASE_URL = ''; // 'https://feeds.elastic.co';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove, not just comment out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

export const NEWSFEED_DEV_SERVICE_BASE_URL = ''; // 'https://feeds-staging.elastic.co';
export const NEWSFEED_DEFAULT_SERVICE_PATH = '/kibana/v{VERSION}.json';
2 changes: 1 addition & 1 deletion src/plugins/newsfeed/kibana.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"id": "newsfeed",
"version": "kibana",
"server": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also make server as false ? If we are not using this code any more ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the Kibana manifest file entirely

"ui": true
"ui": false
}