Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x][Manual][Table Visualization] Replace table visualization with React and DataGrid (#2863) #3198

Merged

Conversation

manasvinibs
Copy link
Member

  • [Table Visualization] Replace table visualization with React and DataGrid

In this PR, we add back functions to make new table usage to be consistent with the replaced one.

  • total function
  • percentage column
  • filter in/out

Meanwhile, we also add back server. Functional tests are removed. We will add new functional test in opensearch-dashboards-functional-test repo. We also clean out some legacy codes.

Issue Resolved:
#2855

Signed-off-by: Anan Zhuang ananzh@amazon.com

  • add some data-test-subj and fix PR comments

Signed-off-by: Anan Zhuang ananzh@amazon.com

  • Fix PR comments and add unit tests

Signed-off-by: Anan Zhuang ananzh@amazon.com

  • remove listenOnChange

Signed-off-by: Anan Zhuang ananzh@amazon.com

Signed-off-by: Anan Zhuang ananzh@amazon.com
(cherry picked from commit 9eedb8e)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@manasvinibs manasvinibs requested a review from a team as a code owner January 6, 2023 18:58
@manasvinibs manasvinibs added the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #3198 (b7bc495) into 2.x (aba9628) will decrease coverage by 0.27%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##              2.x    #3198      +/-   ##
==========================================
- Coverage   66.68%   66.40%   -0.28%     
==========================================
  Files        3220     3199      -21     
  Lines       61544    61199     -345     
  Branches     9432     9415      -17     
==========================================
- Hits        41041    40642     -399     
- Misses      18262    18315      +53     
- Partials     2241     2242       +1     
Flag Coverage Δ
Linux 66.40% <76.47%> (-0.23%) ⬇️
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../plugins/data/common/field_formats/field_format.ts 80.64% <ø> (ø)
...ualizations/table/components/table_viz_options.tsx 0.00% <ø> (ø)
...ilder/public/visualizations/table/to_expression.ts 4.65% <ø> (ø)
.../vega_inspector/components/inspector_data_grid.tsx 5.12% <0.00%> (ø)
...ins/visualizations/public/legacy/build_pipeline.ts 46.28% <ø> (-2.64%) ⬇️
src/plugins/vis_type_table/public/to_ast.ts 91.66% <91.66%> (ø)
src/plugins/vis_type_table/public/table_vis_fn.ts 100.00% <100.00%> (ø)
...arch_dashboards_legacy/public/paginate/paginate.js 0.00% <0.00%> (-89.80%) ⬇️
...c/plugins/data/common/search/aggs/buckets/range.ts 26.31% <0.00%> (-68.43%) ⬇️
...ins/data/public/field_formats/utils/deserialize.ts 20.00% <0.00%> (-60.00%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…Grid (opensearch-project#2863)

* [Table Visualization] Replace table visualization with React and DataGrid

In this PR, we add back functions to make new table usage to
be consistent with the replaced one.
* total function
* percentage column
* filter in/out

Meanwhile, we also add back server. Functional tests are removed.
We will add new functional test in opensearch-dashboards-functional-test
repo. We also clean out some legacy codes.

Issue Resolved:
opensearch-project#2855

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* add some data-test-subj and fix PR comments

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Fix PR comments and add unit tests

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* remove listenOnChange

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 9eedb8e)
@abbyhu2000 abbyhu2000 merged commit 51ddbf6 into opensearch-project:2.x Jan 9, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 9, 2023
…Grid (#2863) (#3198)

* [Table Visualization] Replace table visualization with React and DataGrid

In this PR, we add back functions to make new table usage to
be consistent with the replaced one.
* total function
* percentage column
* filter in/out

Meanwhile, we also add back server. Functional tests are removed.
We will add new functional test in opensearch-dashboards-functional-test
repo. We also clean out some legacy codes.

Issue Resolved:
#2855

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* add some data-test-subj and fix PR comments

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Fix PR comments and add unit tests

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* remove listenOnChange

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 9eedb8e)

Co-authored-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 51ddbf6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3198-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 51ddbf69ec860696489ba8f5ce514d5530f644e2
# Push it to GitHub
git push --set-upstream origin backport/backport-3198-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3198-to-2.x.

abbyhu2000 pushed a commit that referenced this pull request Jan 9, 2023
…Grid (#2863) (#3198) (#3221)

* [Table Visualization] Replace table visualization with React and DataGrid

In this PR, we add back functions to make new table usage to
be consistent with the replaced one.
* total function
* percentage column
* filter in/out

Meanwhile, we also add back server. Functional tests are removed.
We will add new functional test in opensearch-dashboards-functional-test
repo. We also clean out some legacy codes.

Issue Resolved:
#2855

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* add some data-test-subj and fix PR comments

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Fix PR comments and add unit tests

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* remove listenOnChange

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 9eedb8e)

Co-authored-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 51ddbf6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants