Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.5] [Backport 2.x][Manual][Table Visualization] Replace table visualization with React and DataGrid (#2863) #3221

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 51ddbf6 from #3198.

…Grid (#2863) (#3198)

* [Table Visualization] Replace table visualization with React and DataGrid

In this PR, we add back functions to make new table usage to
be consistent with the replaced one.
* total function
* percentage column
* filter in/out

Meanwhile, we also add back server. Functional tests are removed.
We will add new functional test in opensearch-dashboards-functional-test
repo. We also clean out some legacy codes.

Issue Resolved:
#2855

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* add some data-test-subj and fix PR comments

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Fix PR comments and add unit tests

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* remove listenOnChange

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 9eedb8e)

Co-authored-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 51ddbf6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 9, 2023 19:29
@manasvinibs manasvinibs added v2.5.0 'Issues and PRs related to version v2.5.0' autocut Skip the changelog verification check on backports labels Jan 9, 2023
@abbyhu2000 abbyhu2000 merged commit c66782f into 2.5 Jan 9, 2023
@github-actions github-actions bot deleted the backport/backport-3198-to-2.5 branch January 9, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants