Remove unused url #3847
Merged
Remove unused url #3847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>
aoguan1990
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu and
manasvinibs
as code owners
8 tasks
Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>
AMoo-Miki
approved these changes
Apr 14, 2023
8 tasks
abbyhu2000
approved these changes
Apr 14, 2023
aoguan1990
added a commit
to aoguan1990/OpenSearch-Dashboards
that referenced
this pull request
Apr 14, 2023
* Remove unused url Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Add changelog for the cleanup issue Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> --------- Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
* Remove unused url Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Add changelog for the cleanup issue Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> --------- Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
URL: http://roubenmeschian.com/rubo/?p=51 is not reachable by the link checker, which causes the link checker failure. We observed that this url is commented out in the following two files. Clean up is needed to fix the link checker failure.
src/plugins/discover/public/application/angular/doc_table/create_doc_table_react.tsx
src/plugins/discover/public/application/doc_views/doc_views_helpers.tsx
Issues Resolved
Issue #3846
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr