-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Anywhere] Fix legacy tests / bug fixes #4327
[Feature Anywhere] Fix legacy tests / bug fixes #4327
Conversation
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Codecov Report
@@ Coverage Diff @@
## feature/feature-anywhere #4327 +/- ##
============================================================
- Coverage 66.36% 66.34% -0.03%
============================================================
Files 3271 3271
Lines 62997 62998 +1
Branches 9758 9759 +1
============================================================
- Hits 41811 41799 -12
- Misses 18840 18846 +6
- Partials 2346 2353 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Tests are all consistently passing locally:
Errors seen in CI: Missing elements/visualizations:
Other errors seen in run:
This one looks related to
I will try a new local stack with vanilla OSD/ES without any external plugins, such as AD, and see if there is a difference |
Confirmed this still passes locally with vanilla OSD |
Actually - current failures exist in |
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Remaining failures after first fix: |
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Group 7 passing locally
|
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Last completed test run: https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/5336998643 The failures seen there are equivalent to existing failures as seen on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are just what was pulled into the lockfile after re-running bootstrap
. Prefer to include the change so it is consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
45ecc1f
into
opensearch-project:feature/feature-anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - Thanks @ohltyler for the PR summary. It sounds like we were able to catch a few important issues.
Description
This PR gets all legacy functional tests to pass by changing the following:
visibleVisLayers
. Was a miss the first timesavedObjectId
params in the vega expression function pipeline (and downstream vega visualization) which was leftover from the old way of propagating the data down. This was causing an issue where when creating a regular vega visualization, under certain circumstances, would cause the rendering to fail due to missed parameters when generating thevega
expression functionVisLayer
s when rendering the embeddable outside of the context of a dashboard. This is a general improvement, but also fixes a bug where it can put the embeddable in a weird state such that the inspect button is greyed out when first loading a vis in edit view (resolves after re-loading). But this fix prevents that from happening at all