Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport 2.x] Bump OUI to 1.3.0 (#4941) #4946

Merged

Conversation

joshuarrrr
Copy link
Member

Description

Bump OUI to 1.3.0
Add dependency for @opensearch/datemath to osd-ui-shared-deps

Issues Resolved

manual backport of #4941

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #4946 (b5b8a79) into 2.x (2b167df) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x    #4946   +/-   ##
=======================================
  Coverage   66.44%   66.44%           
=======================================
  Files        3399     3399           
  Lines       64881    64881           
  Branches    10360    10360           
=======================================
+ Hits        43107    43109    +2     
+ Misses      19215    19191   -24     
- Partials     2559     2581   +22     
Flag Coverage Δ
Linux_1 34.86% <ø> (-0.05%) ⬇️
Linux_2 55.19% <ø> (ø)
Linux_3 44.25% <ø> (+0.04%) ⬆️
Linux_4 35.05% <ø> (-0.05%) ⬇️
Windows_1 34.88% <ø> (-0.05%) ⬇️
Windows_2 55.15% <ø> (ø)
Windows_3 44.25% <ø> (+0.04%) ⬆️
Windows_4 35.05% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes

AMoo-Miki
AMoo-Miki previously approved these changes Sep 6, 2023
CollapsibleNav vars now provided via theme import
see opensearch-project/oui#968

Signed-off-by: Josh Romero <rmerqg@amazon.com>
kavilla
kavilla previously approved these changes Sep 6, 2023
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry merged another changelog that caused a conflict so I used the GitHub UI to handle it.

@derek-ho
Copy link
Contributor

derek-ho commented Sep 6, 2023

Can we get this in? Our downstream repos may have potentially breaking snapshots from OUI bump and I want to check before code freeze

@ashwin-pc ashwin-pc merged commit 848123d into opensearch-project:2.x Sep 7, 2023
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants