Feat (CollapsibleNavGroup): Make background colors theme-able #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move vars to themes - make `light` and `none` have the same background in `next` theme - explicitly set `none` to `inherit` for existing themes - add warning note to prop description Signed-off-by: Josh Romero <rmerqg@amazon.com>
joshuarrrr
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
andreymyssak and
SergeyMyssak
as code owners
8 tasks
Signed-off-by: Josh Romero <rmerqg@amazon.com>
BSFishy
approved these changes
Aug 16, 2023
…hemeable Signed-off-by: Josh Romero <rmerqg@amazon.com>
joshuarrrr
deleted the
feat/make-collapsible-nav-group-background-themeable
branch
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
* Feat (CollapsibleNavGroup): Make background colors theme-able - move vars to themes - make `light` and `none` have the same background in `next` theme - explicitly set `none` to `inherit` for existing themes - add warning note to prop description Signed-off-by: Josh Romero <rmerqg@amazon.com> * add changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 693ae40) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
joshuarrrr
pushed a commit
that referenced
this pull request
Aug 17, 2023
…978) * Feat (CollapsibleNavGroup): Make background colors theme-able - move vars to themes - make `light` and `none` have the same background in `next` theme - explicitly set `none` to `inherit` for existing themes - add warning note to prop description Signed-off-by: Josh Romero <rmerqg@amazon.com> * add changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 693ae40) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr
added a commit
to joshuarrrr/OpenSearch-Dashboards
that referenced
this pull request
Aug 29, 2023
CollapsibleNav vars now provided via theme import see opensearch-project/oui#968 Signed-off-by: Josh Romero <rmerqg@amazon.com>
joshuarrrr
added a commit
to joshuarrrr/OpenSearch-Dashboards
that referenced
this pull request
Aug 30, 2023
CollapsibleNav vars now provided via theme import see opensearch-project/oui#968 Signed-off-by: Josh Romero <rmerqg@amazon.com>
ashwin-pc
pushed a commit
to opensearch-project/OpenSearch-Dashboards
that referenced
this pull request
Aug 30, 2023
* bump OUI to 1.3.0-beta.2 Signed-off-by: Josh Romero <rmerqg@amazon.com> * Remove unecessary sass import CollapsibleNav vars now provided via theme import see opensearch-project/oui#968 Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com>
joshuarrrr
added a commit
to joshuarrrr/OpenSearch-Dashboards
that referenced
this pull request
Sep 6, 2023
CollapsibleNav vars now provided via theme import see opensearch-project/oui#968 Signed-off-by: Josh Romero <rmerqg@amazon.com>
ashwin-pc
pushed a commit
to opensearch-project/OpenSearch-Dashboards
that referenced
this pull request
Sep 7, 2023
* Bump OUI to `1.3.0` Signed-off-by: Josh Romero <rmerqg@amazon.com> * bump changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> * Remove unecessary sass import CollapsibleNav vars now provided via theme import see opensearch-project/oui#968 Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lightandnonehave the same background innextthemenonetoinheritfor existing themesScreen.Recording.2023-08-16.at.10.38.40.AM.mov
Issues Resolved
Fixes #904
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.