Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Fixes DataTable rendering in discover #5207

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

ashwin-pc
Copy link
Member

Description

Fixes a memoization issue with the datatable component that caused unnecessary and expensive rerenders.

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@ashwin-pc ashwin-pc added backport 2.x discover for discover reinvent de-angular de-angularize work v2.11.0 and removed distinguished-contributor labels Oct 4, 2023
@ashwin-pc ashwin-pc changed the title [Discover] Fixes DataTable rendering in doscover [Discover] Fixes DataTable rendering in discover Oct 4, 2023
@ashwin-pc ashwin-pc added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #5207 (f1c9c54) into main (0ffd2ab) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5207      +/-   ##
==========================================
+ Coverage   66.72%   66.76%   +0.03%     
==========================================
  Files        3278     3278              
  Lines       62999    62999              
  Branches    10031    10031              
==========================================
+ Hits        42035    42059      +24     
+ Misses      18576    18473     -103     
- Partials     2388     2467      +79     
Flag Coverage Δ
Linux_1 35.31% <ø> (ø)
Linux_2 55.24% <ø> (?)
Linux_3 43.74% <ø> (?)
Linux_4 35.42% <ø> (ø)
Windows_1 35.33% <ø> (ø)
Windows_2 55.20% <ø> (ø)
Windows_3 43.75% <ø> (ø)
Windows_4 35.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 21 files with indirect coverage changes

Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ananzh ananzh merged commit c70125f into opensearch-project:main Oct 4, 2023
66 of 87 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-5207-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c70125f13ffe306be5c3fcb5bb4296ffe6dfd3fe
# Push it to GitHub
git push --set-upstream origin backport/backport-5207-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5207-to-2.x.

AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Oct 4, 2023
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit c70125f)
AMoo-Miki added a commit that referenced this pull request Oct 4, 2023
* [BUG][Discover] Add onQuerySubmit to top nav and allow force update to embeddable (#5160)

* all reload to force update embeddable
* add onQuerySubmit to top nav

Issue Resolve
#5116
#5159

Signed-off-by: ananzh <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>

(cherry picked from commit 7d89cca)
Signed-off-by: Miki <miki@amazon.com>

* [Discover] A bunch of navigation fixes (#5168)

* Discover: Fixes state persistence after nav
* Fixed breadcrumbs and navigation
* fixes mobile view

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

(cherry picked from commit cb6e0f0)
Signed-off-by: Miki <miki@amazon.com>

* [BUG][Data Explorer][Discover] Automatically load solo added default index pattern (#5171)

* [BUG][Data Explorer][Discover] Automatically load solo added default index pattern

This fix ensures that when add a default index pattern, Discover will
automatically select and load its details.

Issue Resolve
#5128

---------

Signed-off-by: ananzh <ananzh@amazon.com>

(cherry picked from commit 9601c6c)
Signed-off-by: Miki <miki@amazon.com>

* [BUG][Data Explorer][Discover] Allow data grid to auto adjust size based on fetched data count (#5191)

* This PR adds a new rows state to the DiscoverCanvas component and updated it whenever
the data$ observable emitted new row data.
* The DiscoverTable component was then refactored to accept rows as a prop, making it
dependent on the parent component to provide the correct set of data. This ensures that the table
renders correctly based on the current data and doesn't rely on its internal state,
which could be outdated.

Issue Resolve
#5181

Signed-off-by: ananzh <ananzh@amazon.com>

(cherry picked from commit 677fdf5)
Signed-off-by: Miki <miki@amazon.com>

* Fixes mobile layout (#5195)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit 0ffd2ab)

* [BUG][Data Explorer][Discover] Allow filter and query persist when refresh page or paste url to a new tab (#5206)

Issue Resolve
#5179
#5071

Signed-off-by: ananzh <ananzh@amazon.com>

(cherry picked from commit 5623cef)
Signed-off-by: Miki <miki@amazon.com>

* fixes DataTable rendering in doscover (#5207)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit c70125f)

---------

Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
willie-hung pushed a commit to willie-hung/OpenSearch-Dashboards that referenced this pull request Oct 5, 2023
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Willie Hung <willie880201044@gmail.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 7, 2023
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x de-angular de-angularize work discover for discover reinvent Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants