Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual 2.x] De-angular backports collection #5219

Merged

Conversation

AMoo-Miki
Copy link
Collaborator

Description

Sequential backport of:

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

ananzh and others added 7 commits October 4, 2023 14:34
…o embeddable (opensearch-project#5160)

* all reload to force update embeddable
* add onQuerySubmit to top nav

Issue Resolve
opensearch-project#5116
opensearch-project#5159

Signed-off-by: ananzh <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>

(cherry picked from commit 7d89cca)
Signed-off-by: Miki <miki@amazon.com>
* Discover: Fixes state persistence after nav
* Fixed breadcrumbs and navigation
* fixes mobile view

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

(cherry picked from commit cb6e0f0)
Signed-off-by: Miki <miki@amazon.com>
…index pattern (opensearch-project#5171)

* [BUG][Data Explorer][Discover] Automatically load solo added default index pattern

This fix ensures that when add a default index pattern, Discover will
automatically select and load its details.

Issue Resolve
opensearch-project#5128

---------

Signed-off-by: ananzh <ananzh@amazon.com>

(cherry picked from commit 9601c6c)
Signed-off-by: Miki <miki@amazon.com>
…sed on fetched data count (opensearch-project#5191)

* This PR adds a new rows state to the DiscoverCanvas component and updated it whenever
the data$ observable emitted new row data.
* The DiscoverTable component was then refactored to accept rows as a prop, making it
dependent on the parent component to provide the correct set of data. This ensures that the table
renders correctly based on the current data and doesn't rely on its internal state,
which could be outdated.

Issue Resolve
opensearch-project#5181

Signed-off-by: ananzh <ananzh@amazon.com>

(cherry picked from commit 677fdf5)
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit 0ffd2ab)
…fresh page or paste url to a new tab (opensearch-project#5206)

Issue Resolve
opensearch-project#5179
opensearch-project#5071

Signed-off-by: ananzh <ananzh@amazon.com>

(cherry picked from commit 5623cef)
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit c70125f)
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #5219 (189b5e4) into 2.x (9b1d128) will decrease coverage by 0.03%.
Report is 2 commits behind head on 2.x.
The diff coverage is 18.75%.

@@            Coverage Diff             @@
##              2.x    #5219      +/-   ##
==========================================
- Coverage   66.79%   66.77%   -0.03%     
==========================================
  Files        3278     3278              
  Lines       63042    63053      +11     
  Branches    10028    10030       +2     
==========================================
- Hits        42111    42105       -6     
- Misses      18464    18481      +17     
  Partials     2467     2467              
Flag Coverage Δ
Linux_1 35.32% <ø> (ø)
Linux_2 55.26% <ø> (ø)
Linux_3 43.75% <18.75%> (-0.02%) ⬇️
Linux_4 ?
Windows_1 ?
Windows_2 55.23% <ø> (ø)
Windows_3 43.76% <18.75%> (?)
Windows_4 35.55% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../application/components/sidebar/discover_field.tsx 84.84% <ø> (ø)
...lication/utils/state_management/discover_slice.tsx 45.16% <ø> (ø)
.../discover/public/opensearch_dashboards_services.ts 58.82% <ø> (ø)
...plication/components/top_nav/open_search_panel.tsx 40.00% <0.00%> (+11.42%) ⬆️
...ta_explorer/public/utils/state_management/store.ts 21.42% <21.42%> (+0.73%) ⬆️

... and 5 files with indirect coverage changes

@AMoo-Miki AMoo-Miki changed the title Manual 2.x deangular backports 1 [Manual 2.x] De-angular backports collection Oct 4, 2023
@AMoo-Miki AMoo-Miki merged commit 6d9f4ae into opensearch-project:2.x Oct 4, 2023
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants