[Backport 2.x] [Discover] Data Grid Pagination Options #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
opensearch-trigger-bot
bot
added
discover
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #5701 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 3293 3294 +1
Lines 63359 63370 +11
Branches 10066 10067 +1
=======================================
+ Hits 42496 42505 +9
- Misses 18421 18422 +1
- Partials 2442 2443 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
manasvinibs
force-pushed
the
backport/backport-5610-to-2.x
branch
from
13411ef
to
1e55d09
Compare
manasvinibs
approved these changes
Jan 31, 2024
manasvinibs
force-pushed
the
backport/backport-5610-to-2.x
branch
from
1e55d09
to
61e511c
Compare
* Added helper function to generate page options based on UI setting value. Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> * Added dynamic pagination based on config value for data grid table Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> * Update changelog Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> * Removed service object from the props. Signed-off-by: kishor82 <kishorrathva8298@gmail.com> * Added suggested changes and updated tests. Signed-off-by: kishor82 <kishorrathva8298@gmail.com> * fix functional test issue due to ui setting Signed-off-by: kishor82 <kishorrathva8298@gmail.com> --------- Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com> Signed-off-by: kishor82 <kishorrathva8298@gmail.com> (cherry picked from commit e83b7ee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
manasvinibs
force-pushed
the
backport/backport-5610-to-2.x
branch
from
61e511c
to
c5713c9
Compare
ashwin-pc
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e83b7ee from #5610.